> On Feb. 28, 2016, 8:21 a.m., Adam B wrote: > > Thanks! Couple of tweaks as I review it again. > > - How did you test that this renders correctly? Did you try > > `support/site-docker` to see if the markdown translates properly to html? > > Just because it looks good in github doesn't mean our Rakefile will make it > > look as good.
Yes, I have tried `support/site-docker`. This new doc looks good. > On Feb. 28, 2016, 8:21 a.m., Adam B wrote: > > docs/weights.md, line 16 > > <https://reviews.apache.org/r/42719/diff/3/?file=1259048#file1259048line16> > > > > Are we officially deprecating --weights in this release? If so, we'll > > need to update upgrades.md and the CHANGELOG to mention this. > > > > Could you also document what happens when a master restarts with a > > --weights flag that differs from what's in the registry? (We warn and use > > the registry value, correct?) `--weights` does not deprecate in this release (0.28), for backwark compitibility, it will be deprecated in a future release (Maybe six months later). - Yongqiao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review121129 ----------------------------------------------------------- On Feb. 19, 2016, 7:56 a.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42719/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2016, 7:56 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-3945 > https://issues.apache.org/jira/browse/MESOS-3945 > > > Repository: mesos > > > Description > ------- > > Add doc for weights. > > > Diffs > ----- > > docs/home.md 07214b927c112d7a180507ae03245892455fd757 > docs/weights.md PRE-CREATION > > Diff: https://reviews.apache.org/r/42719/diff/ > > > Testing > ------- > > > Thanks, > > Yongqiao Wang > >
