-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43490/#review118992
-----------------------------------------------------------




src/tests/scheduler_tests.cpp (lines 476 - 483)
<https://reviews.apache.org/r/43490/#comment180289>

    I think that this case cannot cover the case of framework capabaility 
`TASK_KILLING_STATE`, what about update one framework to enable this framework 
can handle the capability of `TASK_KILLING_STATE`? 
    
    Such as 
https://github.com/apache/mesos/blob/master/src/examples/no_executor_framework.cpp#L357-L360


- Guangya Liu


On 二月 11, 2016, 5:12 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43490/
> -----------------------------------------------------------
> 
> (Updated 二月 11, 2016, 5:12 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Qian Zhang.
> 
> 
> Bugs: MESOS-4547
>     https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added testcase for TASK_KILLING state.
> 
> 
> Diffs
> -----
> 
>   src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9 
> 
> Diff: https://reviews.apache.org/r/43490/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Reply via email to