-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43490/#review119285
-----------------------------------------------------------




src/tests/mesos.hpp (line 420)
<https://reviews.apache.org/r/43490/#comment180605>

    
s/DEFAULT_V1_FRAMEWORK_INFO_CAPABILITY/DEFAULT_V1_FRAMEWORK_INFO_TASK_KILLING_STATE
 or someone more meaningful which can be distinguished with 
`REVOCABLE_RESOURCE` capability?



src/tests/mesos.hpp (line 1052)
<https://reviews.apache.org/r/43490/#comment180611>

    1) Keep align with above `v1::FrameworkInfo`
    
    foreach (FrameworkInfo::Capability capability,
             frameworkInfo.get().capabilities()){
             
    2) Add a blank space before `{`



src/tests/scheduler_tests.cpp (line 438)
<https://reviews.apache.org/r/43490/#comment180613>

    Some comments here



src/tests/scheduler_tests.cpp (line 449)
<https://reviews.apache.org/r/43490/#comment180614>

    I think that this can be removed.



src/tests/scheduler_tests.cpp (line 483)
<https://reviews.apache.org/r/43490/#comment180618>

    You are sunscribing a framwork which does not have TASK_KILLING_STATE 
capability, so it should not able to handle the TASK_KILLING_STATE.
    
    I think that here should use `DEFAULT_V1_FRAMEWORK_INFO_CAPABILITY` but not 
`DEFAULT_V1_FRAMEWORK_INFO`
    
    4 spaces here



src/tests/scheduler_tests.cpp (line 556)
<https://reviews.apache.org/r/43490/#comment180620>

    use `DEFAULT_V1_FRAMEWORK_INFO_CAPABILITY` directly here?



src/tests/scheduler_tests.cpp (lines 575 - 576)
<https://reviews.apache.org/r/43490/#comment180616>

    one line



src/tests/scheduler_tests.cpp (lines 578 - 579)
<https://reviews.apache.org/r/43490/#comment180617>

    one line


- Guangya Liu


On 二月 16, 2016, 8:29 a.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43490/
> -----------------------------------------------------------
> 
> (Updated 二月 16, 2016, 8:29 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Qian Zhang.
> 
> 
> Bugs: MESOS-4547
>     https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added testcase for TASK_KILLING state.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp c0997dbacf8753149caba0a8b2406afc35a4845f 
>   src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9 
> 
> Diff: https://reviews.apache.org/r/43490/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Reply via email to