----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43490/#review120045 -----------------------------------------------------------
Hm.. I would expect this patch to be testing the functionality that we've introduced within the command and docker executors, since that's where the logic resides. This does not test the functionality added by the previous patch, why bother mocking out the logic instead of just testing the command and docker executors? - Ben Mahler On Feb. 16, 2016, 6:23 p.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43490/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2016, 6:23 p.m.) > > > Review request for mesos, Ben Mahler and Qian Zhang. > > > Bugs: MESOS-4547 > https://issues.apache.org/jira/browse/MESOS-4547 > > > Repository: mesos > > > Description > ------- > > Added testcase for TASK_KILLING state. > > > Diffs > ----- > > src/tests/mesos.hpp c0997dbacf8753149caba0a8b2406afc35a4845f > src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9 > > Diff: https://reviews.apache.org/r/43490/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Abhishek Dasgupta > >
