> On Feb. 16, 2016, 12:29 a.m., Jie Yu wrote: > > src/slave/containerizer/docker.cpp, lines 1707-1719 > > <https://reviews.apache.org/r/43015/diff/5/?file=1241497#file1241497line1707> > > > > Do you need this? Looks like 'unmountPersistentVolumes' will take care > > of the umount.
We do still need this just in case the container is destroyed right before it's launched but the persistent volumes are already mounted. I think it's better to use unmountVolumes here since we only LOG(ERROR) with custom executors case. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43015/#review119250 ----------------------------------------------------------- On Feb. 15, 2016, 3:39 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43015/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2016, 3:39 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-3413 > https://issues.apache.org/jira/browse/MESOS-3413 > > > Repository: mesos > > > Description > ------- > > Fixed persistent volumes with docker tasks. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3 > src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc > src/tests/containerizer/docker_containerizer_tests.cpp > 645bdcf095145097d8b8c65d592c787417883145 > > Diff: https://reviews.apache.org/r/43015/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
