----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/#review122442 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/mesos.proto (lines 1585 - 1586) <https://reviews.apache.org/r/44004/#comment184447> I wouldn't mention CNI here because if another network isolator is used, it can have different meaning. I would say it's up to the network isolator to decide how to interpret this field. include/mesos/v1/mesos.proto (lines 1582 - 1583) <https://reviews.apache.org/r/44004/#comment184448> Ditto here. - Jie Yu On March 1, 2016, 7:28 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44004/ > ----------------------------------------------------------- > > (Updated March 1, 2016, 7:28 a.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4758 > https://issues.apache.org/jira/browse/MESOS-4758 > > > Repository: mesos > > > Description > ------- > > Add 'name' field into NetworkInfo. > > > Diffs > ----- > > include/mesos/mesos.proto 3d22ec32655dca741169e1f0e382303e061c38b7 > include/mesos/v1/mesos.proto 31960a52061f70d80528fb8326522ae1d6f75b2c > src/common/http.cpp be8538fc222d83d802611392f6c94e80a1e56fa8 > > Diff: https://reviews.apache.org/r/44004/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
