----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review121366 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.hpp (line 302) <https://reviews.apache.org/r/43884/#comment183036> Let's use `typedef` instead. If you do a search this would be the only instance in the codebase of type aliasing using `using`. src/master/allocator/mesos/hierarchical.hpp (line 303) <https://reviews.apache.org/r/43884/#comment183037> I'm even wondering whether `auto` here is a better idea than aliasing. src/master/allocator/mesos/hierarchical.cpp (line 1094) <https://reviews.apache.org/r/43884/#comment183038> Comment in next line. src/master/allocator/mesos/hierarchical.cpp (lines 1100 - 1109) <https://reviews.apache.org/r/43884/#comment183039> As in my previous comments, let's shy away from implicit calling a constructor. I this case I think creating the `Deferred` object outside even makes more sense. - Alexander Rojas On Feb. 29, 2016, 8:59 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43884/ > ----------------------------------------------------------- > > (Updated Feb. 29, 2016, 8:59 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4723 > https://issues.apache.org/jira/browse/MESOS-4723 > > > Repository: mesos > > > Description > ------- > > Added allocator metrics for used quotas. > > > Diffs > ----- > > docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 > src/master/allocator/mesos/hierarchical.hpp > 3043888630b066505410d3b32c5b3f813cc458c1 > src/master/allocator/mesos/hierarchical.cpp > 24fa50f62dec10ed43089297473cc386d6ba2f78 > src/tests/hierarchical_allocator_tests.cpp > 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 > > Diff: https://reviews.apache.org/r/43884/diff/ > > > Testing > ------- > > make check (OS X) > > I confirmed that this does not lead to general performance regressions in the > allocator; this is partially expected since the added code only inserts > metrics in the allocator while the actual work is perform asynchronously. > These tests where performed with > `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build > under OS X using clang(trunk) as compiler. > > > Thanks, > > Benjamin Bannier > >
