----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review122057 -----------------------------------------------------------
docs/monitoring.md (line 905) <https://reviews.apache.org/r/43884/#comment183916> In the same vein as `allocator/allocated/KIND`, this should be something like `allocator/quota/ROLE/allocated/KIND`, right? docs/monitoring.md (line 908) <https://reviews.apache.org/r/43884/#comment183931> s/in use/allocated src/master/allocator/mesos/hierarchical.cpp (lines 1081 - 1092) <https://reviews.apache.org/r/43884/#comment183917> Here we will be also adding a gauge for "set" quotas, a candidate for a helper in `Metrics` src/master/allocator/mesos/hierarchical.cpp (lines 1124 - 1132) <https://reviews.apache.org/r/43884/#comment183919> Let's do it in `Metrics` as well. src/master/allocator/mesos/hierarchical.cpp (line 1820) <https://reviews.apache.org/r/43884/#comment183943> Let's be consistent and call it `_quota_allocated`. Same for the local variable. src/master/allocator/mesos/metrics.hpp (lines 74 - 75) <https://reviews.apache.org/r/43884/#comment183942> let's call it `quota_allocated`. src/master/allocator/mesos/metrics.hpp (line 75) <https://reviews.apache.org/r/43884/#comment183922> two spaces src/tests/hierarchical_allocator_tests.cpp (line 2474) <https://reviews.apache.org/r/43884/#comment183923> s/famework/framework - Alexander Rukletsov On March 3, 2016, 4:17 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43884/ > ----------------------------------------------------------- > > (Updated March 3, 2016, 4:17 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4723 > https://issues.apache.org/jira/browse/MESOS-4723 > > > Repository: mesos > > > Description > ------- > > Added allocator metrics for used quotas. > > > Diffs > ----- > > docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 > src/master/allocator/mesos/hierarchical.hpp > 3043888630b066505410d3b32c5b3f813cc458c1 > src/master/allocator/mesos/hierarchical.cpp > 70291075c00a9a557529c2562dedcfc6c6c3ec32 > src/master/allocator/mesos/metrics.hpp PRE-CREATION > src/master/allocator/mesos/metrics.cpp PRE-CREATION > src/tests/hierarchical_allocator_tests.cpp > 3e4ad31925e1b815a74d67fa3962d23fa5bc89d1 > > Diff: https://reviews.apache.org/r/43884/diff/ > > > Testing > ------- > > make check (OS X) > > I confirmed that this does not lead to general performance regressions in the > allocator; this is partially expected since the added code only inserts > metrics in the allocator while the actual work is perform asynchronously. > These tests where performed with > `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build > under OS X using clang(trunk) as compiler. > > > Thanks, > > Benjamin Bannier > >
