> On March 4, 2016, 2:46 p.m., Alexander Rukletsov wrote:
> > docs/monitoring.md, line 905
> > <https://reviews.apache.org/r/43884/diff/14/?file=1279219#file1279219line905>
> >
> >     In the same vein as `allocator/allocated/KIND`, this should be 
> > something like `allocator/quota/ROLE/allocated/KIND`, right?

Done.


> On March 4, 2016, 2:46 p.m., Alexander Rukletsov wrote:
> > docs/monitoring.md, line 908
> > <https://reviews.apache.org/r/43884/diff/14/?file=1279219#file1279219line908>
> >
> >     s/in use/allocated

Done.


> On March 4, 2016, 2:46 p.m., Alexander Rukletsov wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 1081-1092
> > <https://reviews.apache.org/r/43884/diff/14/?file=1279221#file1279221line1081>
> >
> >     Here we will be also adding a gauge for "set" quotas, a candidate for a 
> > helper in `Metrics`

Set quotas aren't part of this series as they can currently be obtained from a 
master endpoint, while quota allocations cannot.


> On March 4, 2016, 2:46 p.m., Alexander Rukletsov wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 1124-1132
> > <https://reviews.apache.org/r/43884/diff/14/?file=1279221#file1279221line1124>
> >
> >     Let's do it in `Metrics` as well.

Done.


> On March 4, 2016, 2:46 p.m., Alexander Rukletsov wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1820
> > <https://reviews.apache.org/r/43884/diff/14/?file=1279221#file1279221line1820>
> >
> >     Let's be consistent and call it `_quota_allocated`. Same for the local 
> > variable.

Done.


> On March 4, 2016, 2:46 p.m., Alexander Rukletsov wrote:
> > src/master/allocator/mesos/metrics.hpp, lines 74-75
> > <https://reviews.apache.org/r/43884/diff/14/?file=1279222#file1279222line74>
> >
> >     let's call it `quota_allocated`.

Done.


> On March 4, 2016, 2:46 p.m., Alexander Rukletsov wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 2474
> > <https://reviews.apache.org/r/43884/diff/14/?file=1279224#file1279224line2474>
> >
> >     s/famework/framework

Done.


> On March 4, 2016, 2:46 p.m., Alexander Rukletsov wrote:
> > src/master/allocator/mesos/metrics.hpp, line 75
> > <https://reviews.apache.org/r/43884/diff/14/?file=1279222#file1279222line75>
> >
> >     two spaces

I might be wrong, but don't we indent by four spaces, unless we wrap an 
assignment, in which case we indent by two spaces? There's no assignment here.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43884/#review122057
-----------------------------------------------------------


On March 4, 2016, 5:01 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43884/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 5:01 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4723
>     https://issues.apache.org/jira/browse/MESOS-4723
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added allocator metrics for used quotas.
> 
> 
> Diffs
> -----
> 
>   docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3043888630b066505410d3b32c5b3f813cc458c1 
>   src/master/allocator/mesos/hierarchical.cpp 
> 70291075c00a9a557529c2562dedcfc6c6c3ec32 
>   src/master/allocator/mesos/metrics.hpp PRE-CREATION 
>   src/master/allocator/mesos/metrics.cpp PRE-CREATION 
>   src/tests/hierarchical_allocator_tests.cpp 
> 3e4ad31925e1b815a74d67fa3962d23fa5bc89d1 
> 
> Diff: https://reviews.apache.org/r/43884/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the 
> allocator; this is partially expected since the added code only inserts 
> metrics in the allocator while the actual work is perform asynchronously. 
> These tests where performed with 
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build 
> under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to