-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review122030
-----------------------------------------------------------



I think using a `TemporaryDirectoryTest` fixture is the right approach, but 
what I find unfortunate about your approach is that with this patch we'd create 
a temporary directory and incur the overhead for all tests in this suite, even 
ones not creating any files. If that's something we wouldn't want, what about 
using separate suites for tests creating files (that would be `BufferedRead` 
and `Redirect`), and other ones?

- Benjamin Bannier


On March 4, 2016, 8:27 a.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44380/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 8:27 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-4807
>     https://issues.apache.org/jira/browse/MESOS-4807
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit changes IOTest.BufferedRead so that tests could be
> executed from temporary directories via TemporaryDirectoryTest
> fixture (MESOS-4807).
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/io_tests.cpp 
> 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 
> 
> Diff: https://reviews.apache.org/r/44380/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Reply via email to