> On March 4, 2016, 7:42 a.m., Benjamin Bannier wrote:
> > I think using a `TemporaryDirectoryTest` fixture is the right approach, but 
> > what I find unfortunate about your approach is that with this patch we'd 
> > create a temporary directory and incur the overhead for all tests in this 
> > suite, even ones not creating any files. If that's something we wouldn't 
> > want, what about using separate suites for tests creating files (that would 
> > be `BufferedRead` and `Redirect`), and other ones?
> 
> Yong Tang wrote:
>     Hi Benjamin, thanks for the suggestion. I splits IOTest into two test 
> suites. Those tests that will not write files to disk remains the same while 
> the rests (BufferedRead and Redirect) have been moved to 
> TemporaryDirectoryIOTest via TemporaryDirectoryTest fixture. Let me see if 
> there are any issues and I will fix it.

Hi Benjamin, are there any additional issues that need to be addressed in this 
review request? Feedback is appreciated.


- Yong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review122030
-----------------------------------------------------------


On March 4, 2016, 6:56 p.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44380/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 6:56 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-4807
>     https://issues.apache.org/jira/browse/MESOS-4807
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit changes IOTest.BufferedRead so that this specific
> test (not all IOTest) could be executed from temporary
> directories via TemporaryDirectoryTest fixture (MESOS-4807).
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/io_tests.cpp 
> 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 
> 
> Diff: https://reviews.apache.org/r/44380/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Reply via email to