----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44380/#review123382 -----------------------------------------------------------
Looks mostly good to me. I left some comments, but if you want to make any progress here you'll still need to find a shepherd (see http://mesos.apache.org/documentation/latest/submitting-a-patch/). 3rdparty/libprocess/src/tests/io_tests.cpp (line 340) <https://reviews.apache.org/r/44380/#comment185638> IMO this is the right approach, but would pick a different name, e.g., what about `IOWriteTest` or similar? 3rdparty/libprocess/src/tests/io_tests.cpp (line 342) <https://reviews.apache.org/r/44380/#comment185635> Please keep this in its original location. 3rdparty/libprocess/src/tests/io_tests.cpp (line 395) <https://reviews.apache.org/r/44380/#comment185636> Please keep this in its original location. - Benjamin Bannier On March 4, 2016, 7:56 p.m., Yong Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44380/ > ----------------------------------------------------------- > > (Updated March 4, 2016, 7:56 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Bugs: MESOS-4807 > https://issues.apache.org/jira/browse/MESOS-4807 > > > Repository: mesos > > > Description > ------- > > This commit changes IOTest.BufferedRead so that this specific > test (not all IOTest) could be executed from temporary > directories via TemporaryDirectoryTest fixture (MESOS-4807). > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/io_tests.cpp > 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 > > Diff: https://reviews.apache.org/r/44380/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yong Tang > >
