-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43883/
-----------------------------------------------------------
(Updated March 24, 2016, 2:35 p.m.)
Review request for mesos, Alexander Rukletsov and Ben Mahler.
Changes
-------
Changed to report offer filters per role as opposed to per framework.
Summary (updated)
-----------------
Added a metric for querying the number offer filters for a role.
Bugs: MESOS-4722
https://issues.apache.org/jira/browse/MESOS-4722
Repository: mesos
Description (updated)
-------
Added a metric for querying the number offer filters for a role.
Diffs (updated)
-----
docs/monitoring.md dcf19e6ce06b02373a2bd1af81a451a35743fa76
src/master/allocator/mesos/hierarchical.hpp
e4604f4da59166da24709a68b8cd4e56bf55f97f
src/master/allocator/mesos/hierarchical.cpp
39a290d0db2c22e179a8f933b1a78e3a2dcefdc3
src/master/allocator/mesos/metrics.hpp
b5f2806cff99ee2ee46c4ac8a13174ef699969aa
src/master/allocator/mesos/metrics.cpp
2f3012a5bd40a4100e790e1d373832015c80b993
src/tests/hierarchical_allocator_tests.cpp
e9cfcfc0ad8b0b89bbac459b7db39183f6c189be
Diff: https://reviews.apache.org/r/43883/diff/
Testing
-------
make check (OS X)
I confirmed that this does not lead to general performance regressions in the
allocator; this is partially expected since the added code only inserts metrics
in the allocator while the actual work is perform asynchronously. These tests
where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an
optimized build under OS X using clang(trunk) as compiler.
Thanks,
Benjamin Bannier
