> On 三月 5, 2016, 1:25 a.m., Joseph Wu wrote:
> > src/tests/persistent_volume_tests.cpp, line 89
> > <https://reviews.apache.org/r/44408/diff/1/?file=1281379#file1281379line89>
> >
> >     This entire helper is not needed anymore (due to implicit roles).
> 
> Guangya Liu wrote:
>     @Jopseph, why also remove acls here? The implicit roles will only create 
> roles on demand but what about acl?
> 
> Joseph Wu wrote:
>     By default, ACLs are "permissive".  So if a given permission does not 
> exist, Mesos will allow it.  
>     
>     For the majority of the tests that use this helper, they are only using 
> it to set initialize the `role` so that a framework can register.  The 
> ACL-specific tests set up ACLs separately.

Good to know, thanks @Joesph.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44408/#review122163
-----------------------------------------------------------


On 三月 5, 2016, 2:24 a.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44408/
> -----------------------------------------------------------
> 
> (Updated 三月 5, 2016, 2:24 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-4868
>     https://issues.apache.org/jira/browse/MESOS-4868
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This fix removes the setting up of ACLs in PersistentVolumeTests
> as it is no longer needed any more with implicit roles (MESOS-4868).
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp 
> bf19c81fbcf973d1ac27fbd42eedfd7118b7ba50 
> 
> Diff: https://reviews.apache.org/r/44408/diff/
> 
> 
> Testing
> -------
> 
> make check (in Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Reply via email to