> On March 5, 2016, 2:31 a.m., Joseph Wu wrote: > > src/tests/persistent_volume_tests.cpp, lines 283-284 > > <https://reviews.apache.org/r/44408/diff/2/?file=1281647#file1281647line283> > > > > One more small refinement: > > > > Now that the master does not use this variable, you should move it > > above the `MesosSchedulerDriver driver(...);`. > > > > Ditto for all modified tests.
Thanks Joseph. Just updated the Review Request. Let me know if there are any other issues. - Yong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/#review122173 ----------------------------------------------------------- On March 5, 2016, 4:17 a.m., Yong Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44408/ > ----------------------------------------------------------- > > (Updated March 5, 2016, 4:17 a.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-4868 > https://issues.apache.org/jira/browse/MESOS-4868 > > > Repository: mesos > > > Description > ------- > > This fix removes the setting up of ACLs in PersistentVolumeTests > as it is no longer needed any more with implicit roles (MESOS-4868). > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp > bf19c81fbcf973d1ac27fbd42eedfd7118b7ba50 > > Diff: https://reviews.apache.org/r/44408/diff/ > > > Testing > ------- > > make check (in Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
