-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44408/#review122346
-----------------------------------------------------------


Fix it, then Ship it!




LGTM.

You should probably ask Adam to shepherd since he committed the other implicit 
roles patches.


src/tests/persistent_volume_tests.cpp (lines 271 - 275)
<https://reviews.apache.org/r/44408/#comment184302>

    Nit: An arrangement like this is preferable:
    ```
      FrameworkInfo frameworkInfo = DEFAULT_FRAMEWORK_INFO;
      frameworkInfo.set_role("role1");
      
      MockScheduler sched;
      MesosSchedulerDriver driver(
          &sched, frameworkInfo, master.get(), DEFAULT_CREDENTIAL);
    ```


- Joseph Wu


On March 4, 2016, 8:17 p.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44408/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 8:17 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-4868
>     https://issues.apache.org/jira/browse/MESOS-4868
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This fix removes the setting up of ACLs in PersistentVolumeTests
> as it is no longer needed any more with implicit roles (MESOS-4868).
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp 
> bf19c81fbcf973d1ac27fbd42eedfd7118b7ba50 
> 
> Diff: https://reviews.apache.org/r/44408/diff/
> 
> 
> Testing
> -------
> 
> make check (in Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Reply via email to