----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/#review122672 -----------------------------------------------------------
Bad review! Reviews applied: [44289] Error: No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list. - Mesos ReviewBot On March 9, 2016, 1:39 a.m., Anurag Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44289/ > ----------------------------------------------------------- > > (Updated March 9, 2016, 1:39 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > ------- > > Added support for contender and detector modules. > > > Diffs > ----- > > include/mesos/module/contender.hpp PRE-CREATION > include/mesos/module/detector.hpp PRE-CREATION > src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 > src/examples/test_contender_module.cpp PRE-CREATION > src/examples/test_detector_module.cpp PRE-CREATION > src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9 > src/master/contenders/zookeeper.cpp > 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 > src/master/detectors/zookeeper.cpp 9274435802d6292b183be48f42b43999476e016e > src/module/manager.cpp 6ae99504005581b22a44768949b1d305cec517d9 > src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 > src/tests/module.cpp 8cc305c0ef606b07eea39d548d3165a2bb2b042a > > Diff: https://reviews.apache.org/r/44289/diff/ > > > Testing > ------- > > In addition to all unit tests passing, we are currently using this > functionality in our environment with a custom consensus stack. In our world, > we have a C++ plugin that calls out to an HTTP REST service (implemented in > Java/Scala, not that it matters). > > > Thanks, > > Anurag Singh > >
