----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/#review122691 -----------------------------------------------------------
Fix it, then Ship it! Looks great! One more little bit of cleanup, and I'll commit it. src/tests/persistent_volume_tests.cpp (line 683) <https://reviews.apache.org/r/44408/#comment184797> `StartMaster()` without any parameters will call `CreateMasterFlags()` anyway, so just drop the `CreateMasterFlags()`. - Adam B On March 7, 2016, 12:55 p.m., Yong Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44408/ > ----------------------------------------------------------- > > (Updated March 7, 2016, 12:55 p.m.) > > > Review request for mesos, Adam B and Joseph Wu. > > > Bugs: MESOS-4868 > https://issues.apache.org/jira/browse/MESOS-4868 > > > Repository: mesos > > > Description > ------- > > This fix removes the setting up of ACLs in PersistentVolumeTests > as it is no longer needed any more with implicit roles (MESOS-4868). > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp > bf19c81fbcf973d1ac27fbd42eedfd7118b7ba50 > > Diff: https://reviews.apache.org/r/44408/diff/ > > > Testing > ------- > > make check (in Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
