-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44087/#review122977
-----------------------------------------------------------




src/slave/containerizer/mesos/linux_launcher.cpp (lines 247 - 255)
<https://reviews.apache.org/r/44087/#comment185088>

    Can we add a small note here that we rely on the child being blocked 
through the Hook infrastructure, and that's why it's safe to freeze the child 
this way?



src/slave/containerizer/mesos/linux_launcher.cpp (line 249)
<https://reviews.apache.org/r/44087/#comment185072>

    let's wrap all the arguments.



src/slave/containerizer/mesos/linux_launcher.cpp (lines 250 - 251)
<https://reviews.apache.org/r/44087/#comment185073>

    Why are we taking these by const value?



src/slave/containerizer/mesos/linux_launcher.cpp (lines 273 - 277)
<https://reviews.apache.org/r/44087/#comment185085>

    What should we do here now that the hook infrastructure is in place?
    Should we log an error as well as return one? or return a more meaningful 
error message?



src/slave/containerizer/mesos/linux_launcher.cpp (line 276)
<https://reviews.apache.org/r/44087/#comment185084>

    We now rely on the hook logic to do this right?
    Let's document this.



src/slave/containerizer/mesos/linux_launcher.cpp (lines 306 - 317)
<https://reviews.apache.org/r/44087/#comment185086>

    Does the order here matter?
    If not can we make a note?



src/slave/containerizer/mesos/linux_launcher.cpp (lines 318 - 319)
<https://reviews.apache.org/r/44087/#comment185087>

    Now that we've gutted the pipe logic, can we add a `NOTE:` that the child 
process will be blocked until the hooks have finished?


- Joris Van Remoortere


On March 3, 2016, 3:39 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44087/
> -----------------------------------------------------------
> 
> (Updated March 3, 2016, 3:39 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved logic to assign process to freezer hierarchy into parentHook.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> 9c80cfb621ef2e28aabfb2649846892964d2d4f3 
> 
> Diff: https://reviews.apache.org/r/44087/diff/
> 
> 
> Testing
> -------
> 
> sudo make check (on Linux)
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to