> On March 8, 2016, 6:57 p.m., Guangya Liu wrote:
> > src/tests/containerizer/docker_archive.hpp, lines 70-75
> > <https://reviews.apache.org/r/43956/diff/5/?file=1283302#file1283302line70>
> >
> >     Two layer will not work with bind backend, does it make sense to enable 
> > `create` can specify if only want one layer?
> >     
> >     I think that supportting two cases is enough: one layer image and two 
> > layers iamge.
> >     
> >     static Future<Nothing> create(
> >         const std::string& directory,
> >         const std::string& name,
> >         const std::string& entrypoint = "null",
> >         const std::string& cmd = "null",
> >         const bool onelayer = false)

Thanks, Guangya. I just make it `alpine`. )


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43956/#review122662
-----------------------------------------------------------


On March 10, 2016, 3:37 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43956/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 3:37 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4684
>     https://issues.apache.org/jira/browse/MESOS-4684
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Created base docker image for test suite.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
>   src/tests/containerizer/docker_archive.hpp PRE-CREATION 
>   src/tests/containerizer/runtime_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43956/diff/
> 
> 
> Testing
> -------
> 
> (Ubuntu14.04 + clang-3.6)
> 
> make -j24 check GTEST_FILTER="*ROOT_RUNTIME_CreateDockerLocalTar*" 
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="*ROOT_RUNTIME_CreateDockerLocalTar*"
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Reply via email to