> On March 10, 2016, 6:22 p.m., Jie Yu wrote: > >
I think we should not use `Option<string>` here, because in a docker manifest, it does not exist None case. If any field does not exist, it should be JSON::null. Entrypoint/cmd should be either JSON::null or a JSON::array `["a", "b", ...]`. So we should change these parameters back to `string`. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43956/#review123068 ----------------------------------------------------------- On March 10, 2016, 3:37 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43956/ > ----------------------------------------------------------- > > (Updated March 10, 2016, 3:37 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-4684 > https://issues.apache.org/jira/browse/MESOS-4684 > > > Repository: mesos > > > Description > ------- > > Created base docker image for test suite. > > > Diffs > ----- > > src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 > src/tests/containerizer/docker_archive.hpp PRE-CREATION > src/tests/containerizer/runtime_isolator_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/43956/diff/ > > > Testing > ------- > > (Ubuntu14.04 + clang-3.6) > > make -j24 check GTEST_FILTER="*ROOT_RUNTIME_CreateDockerLocalTar*" > > sudo ./bin/mesos-tests.sh --gtest_filter="*ROOT_RUNTIME_CreateDockerLocalTar*" > > > Thanks, > > Gilbert Song > >
