-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43956/#review123173
-----------------------------------------------------------




src/tests/containerizer/docker_archive.hpp (line 169)
<https://reviews.apache.org/r/43956/#comment185347>

    We don't need clear anyfiles we created before once failed, right?



src/tests/containerizer/docker_archive.hpp (line 212)
<https://reviews.apache.org/r/43956/#comment185346>

    Do we need pass a value to avoid it await forever? Above code also have 
another tarRootfs.await()


- haosdent huang


On March 10, 2016, 11:37 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43956/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 11:37 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4684
>     https://issues.apache.org/jira/browse/MESOS-4684
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Created base docker image for test suite.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
>   src/tests/containerizer/docker_archive.hpp PRE-CREATION 
>   src/tests/containerizer/runtime_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43956/diff/
> 
> 
> Testing
> -------
> 
> (Ubuntu14.04 + clang-3.6)
> 
> make -j24 check GTEST_FILTER="*ROOT_RUNTIME_CreateDockerLocalTar*" 
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="*ROOT_RUNTIME_CreateDockerLocalTar*"
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Reply via email to