-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44549/#review123148
-----------------------------------------------------------




src/CMakeLists.txt (line 52)
<https://reviews.apache.org/r/44549/#comment185323>

    Should we have a sub-directory called `cni` and add thes spec to the 
sub-directory. Just in case there are other specs that come around and we want 
to support them?



src/CMakeLists.txt (line 275)
<https://reviews.apache.org/r/44549/#comment185324>

    Ditto on the `cni` path?



src/Makefile.am (lines 234 - 235)
<https://reviews.apache.org/r/44549/#comment185325>

    Ditto on the `cni` path?



src/slave/containerizer/mesos/isolators/network/spec.proto (line 46)
<https://reviews.apache.org/r/44549/#comment185327>

    Can we list the required field before the optional fields? We can keep the 
position identifiers as is, if required.



src/slave/containerizer/mesos/isolators/network/spec.proto (line 57)
<https://reviews.apache.org/r/44549/#comment185326>

    Ditto on arrangement of required followed by optional fields.


- Avinash sridharan


On March 10, 2016, 2:44 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44549/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 2:44 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
>     https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced a protobuf message "NetworkConfig".
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/slave/containerizer/mesos/isolators/network/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/spec.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44549/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Reply via email to