-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44549/#review123170
-----------------------------------------------------------




src/CMakeLists.txt (line 52)
<https://reviews.apache.org/r/44549/#comment185342>

    +1 on moving into cni/ subdirectory.
    
    I think we might want to introduce a few helper functions (e.g., parsing) 
in a separate hpp|cpp.



src/slave/containerizer/mesos/isolators/network/spec.proto (line 23)
<https://reviews.apache.org/r/44549/#comment185348>

    OK, this is my bad. I didn't realize that network configuration JSON will 
inline some plugin specific or ipam specific fields.
    
    In that case, I would suggest that we only list well-known fields and do 
not list plugin or ipam specific field in this protobuf.
    
    You can take a look at:
    https://github.com/appc/cni/blob/master/pkg/types/types.go#L59
    
    I think json->protobuf parsing should still work if there are missing 
fields in the protobuf.



src/slave/containerizer/mesos/isolators/network/spec.proto (lines 31 - 34)
<https://reviews.apache.org/r/44549/#comment185351>

    Those are ipam specific, let's remote those.



src/slave/containerizer/mesos/isolators/network/spec.proto (lines 45 - 55)
<https://reviews.apache.org/r/44549/#comment185343>

    What's this?



src/slave/containerizer/mesos/isolators/network/spec.proto (line 60)
<https://reviews.apache.org/r/44549/#comment185352>

    This is plugin specific, let's remove this from this protobuf.



src/slave/containerizer/mesos/isolators/network/spec.proto (line 61)
<https://reviews.apache.org/r/44549/#comment185353>

    Ditto.



src/slave/containerizer/mesos/isolators/network/spec.proto (lines 63 - 67)
<https://reviews.apache.org/r/44549/#comment185354>

    Remove these as well.


- Jie Yu


On March 10, 2016, 2:44 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44549/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 2:44 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
>     https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced a protobuf message "NetworkConfig".
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/slave/containerizer/mesos/isolators/network/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/spec.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44549/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Reply via email to