> On March 11, 2016, 6:19 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/spec.proto, line 23
> > <https://reviews.apache.org/r/44549/diff/2/?file=1294410#file1294410line23>
> >
> >     OK, this is my bad. I didn't realize that network configuration JSON 
> > will inline some plugin specific or ipam specific fields.
> >     
> >     In that case, I would suggest that we only list well-known fields and 
> > do not list plugin or ipam specific field in this protobuf.
> >     
> >     You can take a look at:
> >     https://github.com/appc/cni/blob/master/pkg/types/types.go#L59
> >     
> >     I think json->protobuf parsing should still work if there are missing 
> > fields in the protobuf.

I agree. Have raised an issue to isolate the plugin/ipam specific fields into 
their own dictionaries:
https://github.com/appc/cni/issues/128


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44549/#review123170
-----------------------------------------------------------


On March 10, 2016, 2:44 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44549/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 2:44 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
>     https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced a protobuf message "NetworkConfig".
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/slave/containerizer/mesos/isolators/network/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/spec.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44549/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Reply via email to