> On March 14, 2016, 2:29 p.m., Benjamin Bannier wrote:
> > src/python/native_common/ext_modules.py.in, line 128
> > <https://reviews.apache.org/r/44785/diff/1/?file=1297270#file1297270line128>
> >
> >     Could we instead make that decision based on the tool used instead of 
> > just the platform? LLVM's lld supports `--as-needed` now, or a user could 
> > link with gcc (e.g., via homebrew).

Is there an example of that elsewhere?  Specifically detecting if a certain 
flag exists?


- Steve


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44785/#review123413
-----------------------------------------------------------


On March 14, 2016, 2:21 p.m., Steve Niemitz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44785/
> -----------------------------------------------------------
> 
> (Updated March 14, 2016, 2:21 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Don't use --as-needed on OSX.
> 
> 
> Diffs
> -----
> 
>   src/python/native_common/ext_modules.py.in 
> 0a005dc5746aec428be6dbaf02e58f293d87a05c 
> 
> Diff: https://reviews.apache.org/r/44785/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Reply via email to