----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/#review123533 -----------------------------------------------------------
src/slave/flags.cpp (line 531) <https://reviews.apache.org/r/44661/#comment185783> Seems like we usually just specify that "This flag is deprecated, ....." in the other places in the code base. I prefer to big bold fonts like this but I don't want us to have many different ways to mark deprecation either. I say we keep it all consistent. - Timothy Chen On March 14, 2016, 5:51 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44661/ > ----------------------------------------------------------- > > (Updated March 14, 2016, 5:51 p.m.) > > > Review request for mesos, Ben Mahler and Timothy Chen. > > > Bugs: MESOS-4910 > https://issues.apache.org/jira/browse/MESOS-4910 > > > Repository: mesos > > > Description > ------- > > Instead, a combination of `executor_shutdown_grace_period` > agent flag and task kill policies should be used. > > > Diffs > ----- > > docs/configuration.md 739d4ff9aeeb1ba70ce11033168d63d37b6ef56b > src/docker/executor.hpp abbc419533ab40312e917931a2fc2ce78b38da41 > src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 > src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 > src/slave/flags.cpp 5bacf109bcd9c9eae1b7ec3c32095c72899ebdbd > > Diff: https://reviews.apache.org/r/44661/diff/ > > > Testing > ------- > > The complete chain was tested. See https://reviews.apache.org/r/44662/. > > > Thanks, > > Alexander Rukletsov > >
