> On March 19, 2016, 2:16 a.m., Ben Mahler wrote:
> > Ok I misunderstood what the intent was here. Generally when we say 
> > "deprecated" we maintain the old behavior and we plan to remove the support 
> > in a future version. This doesn't maintain the old behavior, why not leave 
> > as is and we do a clean break once the deprecation cycle is finished?

Also, can you include a CHANGELOG update in this patch? It's much cleaner on 
master and easier for posterity if the deprecation is coupled with the user 
documentation (i.e. what they should do instead of using this flag).


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44661/#review124361
-----------------------------------------------------------


On March 18, 2016, 5:23 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44661/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 5:23 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Bugs: MESOS-4910
>     https://issues.apache.org/jira/browse/MESOS-4910
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead, a combination of `executor_shutdown_grace_period`
> agent flag and task kill policies should be used.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md d10fa2e7fc7c477de2f0e30e10da6d817ecbf404 
>   src/docker/executor.hpp abbc419533ab40312e917931a2fc2ce78b38da41 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
>   src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
>   src/slave/flags.cpp b77afa956834bb5b1f85301d7a5f386ab9da41e3 
> 
> Diff: https://reviews.apache.org/r/44661/diff/
> 
> 
> Testing
> -------
> 
> The complete chain was tested. See https://reviews.apache.org/r/44662/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to