----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44777/#review123573 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp (line 64) <https://reviews.apache.org/r/44777/#comment185799> Typo. Also, "i.e.," is usually preferrable. 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp (line 69) <https://reviews.apache.org/r/44777/#comment185802> I wonder if this variable would be better named `result`. 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp (line 76) <https://reviews.apache.org/r/44777/#comment185801> Remove whitespace before string literal 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp (line 80) <https://reviews.apache.org/r/44777/#comment185800> Newline here? - Neil Conway On March 15, 2016, 2:23 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44777/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 2:23 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-4926 > https://issues.apache.org/jira/browse/MESOS-4926 > > > Repository: mesos > > > Description > ------- > > Added a flags parser for vector<unsigned int> to stout. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp > 295eac77d5aba4084bbc044d94f45d660410d725 > > Diff: https://reviews.apache.org/r/44777/diff/ > > > Testing > ------- > > Ran `make` and `make check` > > This is also tested out in a subsequent commit when adding support for the > `--nvidia_gpu_devices` flag, which uses this functionality. > > > Thanks, > > Kevin Klues > >
