----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44853/#review123736 -----------------------------------------------------------
Patch looks great! Reviews applied: [44853] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 15, 2016, 2:52 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44853/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 2:52 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > Added benchmark test for the allocator metrics endpoint. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 459e02576f6d05abbbcc83ae5cabac5c66e93f05 > > Diff: https://reviews.apache.org/r/44853/diff/ > > > Testing > ------- > > The benchmark uses the same parametrized setup as other > `HierarchicalAllocator_BENCHMARK_Tests` which already elsewhere take > considerable time. The reason for covering the same parameter space here was > the assumption that that parameter space does capture the relevant scenarios. > > The benchmark shows that the time needed to obtain the metrics has a linear > relationship with the number of registered frameworks, roughly independent of > the number of slaves. With my setup, the time per framework was well below 1 > ms after already a few frameworks. > > > Thanks, > > Benjamin Bannier > >
