----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/ -----------------------------------------------------------
(Updated March 15, 2016, 11:01 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description ------- Instead of keeping standalone and zookeper contender/detector class definitions and implementations in the same file, separated them. Also made the necessary changes in users of class headers to point to the new locations. Diffs ----- src/Makefile.am 7ee5a653fc96907021f14ab28f74c0b3ed0649d9 src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 src/master/contenders/contender.hpp PRE-CREATION src/master/contenders/contender.cpp PRE-CREATION src/master/contenders/standalone.cpp PRE-CREATION src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e src/master/detectors/detector.hpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION src/master/detectors/standalone.cpp PRE-CREATION src/master/main.cpp 7c1656bcc266f6c94cb4befad37fa813a218b2fa src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 src/tests/cluster.cpp e5796d3cc17f814bec8f02dccf40515b65cfea91 src/tests/containerizer/external_containerizer_test.cpp 8e1dbe306a088eb16cd3b9c6174b95fad5685da4 src/tests/containerizer/isolator_tests.cpp 342037ce0a5f8caa4e3cf1550b8f9a7cc328acf9 src/tests/fault_tolerance_tests.cpp 349669d6aa0ead63b2ebcfcc2f769c99a6db0192 src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 src/tests/master_authorization_tests.cpp 6a4de4709960d7ca505e99396e14a1bb51d6902d src/tests/master_contender_detector_tests.cpp 255ab8119a04b55bb4f1b61dee19c4be64499376 src/tests/master_slave_reconciliation_tests.cpp d41178eb41df519073fc0890c5716bbc9fed6ad2 src/tests/master_tests.cpp e8c39e775d6ca218ce74cfc6bb50c7576d73e90e src/tests/mesos.hpp 908a53a146208a6d41c0bda5208415e39e2eae05 src/tests/oversubscription_tests.cpp e528476cd83b0e3f7ae8cea7d86dfabc1f66484e src/tests/partition_tests.cpp 3776a0a104582f60b9f19ea58b011485194399b9 src/tests/persistent_volume_tests.cpp e9215de2e073025f67cdc73e8a8de38cf030671f src/tests/reconciliation_tests.cpp e8f3f29836652d20a6ee1bb5231a15e71eb76990 src/tests/reservation_tests.cpp c88091635949037fcfc6be504043764f9af35f79 src/tests/scheduler_event_call_tests.cpp 8c02ceeb3ec1783cb2f63f100700508e70f586e4 src/tests/scheduler_http_api_tests.cpp dfb0f51fec67a3951e396eab28eedb0dbf9493ae src/tests/scheduler_tests.cpp fa42fb42f2d18060a867ade547cebbdcaead07d4 src/tests/slave_recovery_tests.cpp bd7b94f3f1fac6705e5bf14c6f6103b540cde56c src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 Diff: https://reviews.apache.org/r/44545/diff/ Testing (updated) ------- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh