-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44657/#review124352
-----------------------------------------------------------


Fix it, then Ship it!





src/launcher/executor.cpp (line 924)
<https://reviews.apache.org/r/44657/#comment186845>

    It doesn't crash, it just exits :)



src/launcher/executor.cpp (lines 925 - 926)
<https://reviews.apache.org/r/44657/#comment186846>

    Or remove flags



src/slave/slave.cpp (line 3691)
<https://reviews.apache.org/r/44657/#comment186844>

    Can you pull Seconds(1) down to the next line so that each component of the 
sum is on a separate line?


- Ben Mahler


On March 18, 2016, 5:19 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44657/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 5:19 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Gilbert Song.
> 
> 
> Bugs: MESOS-4909
>     https://issues.apache.org/jira/browse/MESOS-4909
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The command executor determines how much time it allots the
> underlying task to clean up (effectively how long to wait for
> the task to comply to SIGTERM before sending SIGKILL) based
> on both optional task's `KillPolicy` and optional
> `shutdown_grace_period` field in `ExecutorInfo`.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
> 
> Diff: https://reviews.apache.org/r/44657/diff/
> 
> 
> Testing
> -------
> 
> The complete chain was tested. See https://reviews.apache.org/r/44662/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to