----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44657/#review124359 -----------------------------------------------------------
src/launcher/executor.cpp (lines 496 - 499) <https://reviews.apache.org/r/44657/#comment186862> I added this TODO for killTask, can you help by clarifying that the shutdown arrives after a kill task? - Ben Mahler On March 18, 2016, 5:19 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44657/ > ----------------------------------------------------------- > > (Updated March 18, 2016, 5:19 p.m.) > > > Review request for mesos, Ben Mahler and Gilbert Song. > > > Bugs: MESOS-4909 > https://issues.apache.org/jira/browse/MESOS-4909 > > > Repository: mesos > > > Description > ------- > > The command executor determines how much time it allots the > underlying task to clean up (effectively how long to wait for > the task to comply to SIGTERM before sending SIGKILL) based > on both optional task's `KillPolicy` and optional > `shutdown_grace_period` field in `ExecutorInfo`. > > > Diffs > ----- > > src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e > src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 > > Diff: https://reviews.apache.org/r/44657/diff/ > > > Testing > ------- > > The complete chain was tested. See https://reviews.apache.org/r/44662/. > > > Thanks, > > Alexander Rukletsov > >
