----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42684/#review124120 -----------------------------------------------------------
Fix it, then Ship it! src/tests/persistent_volume_tests.cpp (line 152) <https://reviews.apache.org/r/42684/#comment186503> Personally I would find this clearer if the order of operands was reversed, e.g., `CHECK_GE(id, 1)` src/tests/persistent_volume_tests.cpp (line 204) <https://reviews.apache.org/r/42684/#comment186504> `constexpr`? And name this `NUM_DISKS`? src/tests/persistent_volume_tests.cpp (line 229) <https://reviews.apache.org/r/42684/#comment186501> Typo ("privileges") src/tests/persistent_volume_tests.cpp (line 290) <https://reviews.apache.org/r/42684/#comment186502> Can you add a comment (e.g., to commit message) why you're changing all these disk resources sizes to be larger? - Neil Conway On Jan. 26, 2016, 8:20 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42684/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2016, 8:20 p.m.) > > > Review request for mesos, Jie Yu and Michael Park. > > > Bugs: MESOS-191 > https://issues.apache.org/jira/browse/MESOS-191 > > > Repository: mesos > > > Description > ------- > > Multiple Disk: Added persistent volumes tests for `MOUNT` type. > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp > cbf2bcedd5b4c14107d3b50a74f161aa9395d7d0 > src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23 > > Diff: https://reviews.apache.org/r/42684/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Joris Van Remoortere > >
