> On March 17, 2016, 11:31 p.m., Neil Conway wrote:
> >

Thanks for the review!


> On March 17, 2016, 11:31 p.m., Neil Conway wrote:
> > src/tests/persistent_volume_tests.cpp, line 152
> > <https://reviews.apache.org/r/42684/diff/5/?file=1221796#file1221796line152>
> >
> >     Personally I would find this clearer if the order of operands was 
> > reversed, e.g., `CHECK_GE(id, 1)`

I agree. I wanted to write it that way, but it would void the `expected, 
actual` policy. I chose to stick with consistency in this case.


- Joris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/#review124120
-----------------------------------------------------------


On March 21, 2016, 10:37 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42684/
> -----------------------------------------------------------
> 
> (Updated March 21, 2016, 10:37 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Michael Park.
> 
> 
> Bugs: MESOS-191
>     https://issues.apache.org/jira/browse/MESOS-191
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Multiple Disk: Added persistent volumes tests for `MOUNT` type.
> 
> Made volume sizes consistent with disk sizes to conform with `MOUNT`
> requirements.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp 
> 26fff19daa8b175fdcc06fd9467224d5920a1967 
>   src/tests/resources_tests.cpp 6b004d64bb25112b19fc5d98b5bca874c5329e8c 
> 
> Diff: https://reviews.apache.org/r/42684/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to