-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/#review124499
-----------------------------------------------------------



It would be great to have a unit test that verifies that when a task using a 
`MOUNT` volume exceeds the disk space on the volume, the task gets an error on 
the disk write, which it can then handle as appropriate (this is important 
behavior for some use-cases of the `MOUNT` feature). This test might be out of 
scope for this RR -- let me know if you'd like me to open a JIRA.

- Neil Conway


On March 18, 2016, 10:46 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42684/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 10:46 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Michael Park.
> 
> 
> Bugs: MESOS-191
>     https://issues.apache.org/jira/browse/MESOS-191
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Multiple Disk: Added persistent volumes tests for `MOUNT` type.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp 
> 26fff19daa8b175fdcc06fd9467224d5920a1967 
>   src/tests/resources_tests.cpp 6b004d64bb25112b19fc5d98b5bca874c5329e8c 
> 
> Diff: https://reviews.apache.org/r/42684/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to