----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/#review124511 -----------------------------------------------------------
Need to get rid of the unnecessary stringify/atof translation, but I like the new low-level registry Operation test. src/tests/registrar_tests.cpp (line 196) <https://reviews.apache.org/r/44511/#comment187097> s/string/const string&/ And this is a static function, not using any class "state". Better off just making it a free-standing test helper function, outside of the class. src/tests/registrar_tests.cpp (lines 909 - 913) <https://reviews.apache.org/r/44511/#comment187098> No need to make these `const`, but if you do, you might as well make them const-refs. src/tests/registrar_tests.cpp (lines 910 - 915) <https://reviews.apache.org/r/44511/#comment187099> I don't understand why you stringify your double weights, then parse them and call atof just to get it back to a double to store in WeightInfo. Could you write a helper function that instead makes a `vector<WeightInfo>` from a `vector<string>, vector<double>` or maybe just a `WeightInfo createWeightInfo(string, double)`? Neither require stringify/atof - Adam B On March 14, 2016, 6:52 a.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44511/ > ----------------------------------------------------------- > > (Updated March 14, 2016, 6:52 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-4797 > https://issues.apache.org/jira/browse/MESOS-4797 > > > Repository: mesos > > > Description > ------- > > Add registry tests for /weights endpoint. > > > Diffs > ----- > > src/tests/dynamic_weights_tests.cpp > a95663f633f376954d4201b6cfbe693429be9c39 > src/tests/registrar_tests.cpp c330af2a190282e159d9ab477cdc36a7881842cd > > Diff: https://reviews.apache.org/r/44511/diff/ > > > Testing > ------- > > Add three sub tests for /weights endpoint registry in this patch: > > 1. Tests whether the weights replicated log is initialized with the > `--weights` flag when bootstrapping the cluster. > 2. Tests whether the weights replicated log can be updated with `/weights` > endpoint. > 3. Tests whether the `--weights` flag is ignored and use the registry value > instead when Mesos master subsequently starts with `--weights` flag still > specified. > > ./src/mesos-tests --gtest_filter=Strict/RegistrarTest.UpdateWeights/* > [==========] Running 2 tests from 1 test case. > [----------] Global test environment set-up. > [----------] 2 tests from Strict/RegistrarTest > [ RUN ] Strict/RegistrarTest.UpdateWeights/0 > [ OK ] Strict/RegistrarTest.UpdateWeights/0 (103 ms) > [ RUN ] Strict/RegistrarTest.UpdateWeights/1 > [ OK ] Strict/RegistrarTest.UpdateWeights/1 (67 ms) > [----------] 2 tests from Strict/RegistrarTest (171 ms total) > > [----------] Global test environment tear-down > [==========] 2 tests from 1 test case ran. (178 ms total) > [ PASSED ] 2 tests. > > > make && make check. > > > Thanks, > > Yongqiao Wang > >