----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/#review124531 -----------------------------------------------------------
Bad patch! Reviews applied: [44511, 41790, 44512, 43863, 41681] Failed command: ./support/apply-review.sh -n -r 44511 Error: 2016-03-21 11:19:24 URL:https://reviews.apache.org/r/44511/diff/raw/ [11292/11292] -> "44511.patch" [1] error: patch failed: src/tests/dynamic_weights_tests.cpp:459 error: src/tests/dynamic_weights_tests.cpp: patch does not apply Full log: https://builds.apache.org/job/mesos-reviewbot/12073/console - Mesos ReviewBot On March 14, 2016, 1:52 p.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44511/ > ----------------------------------------------------------- > > (Updated March 14, 2016, 1:52 p.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-4797 > https://issues.apache.org/jira/browse/MESOS-4797 > > > Repository: mesos > > > Description > ------- > > Add registry tests for /weights endpoint. > > > Diffs > ----- > > src/tests/dynamic_weights_tests.cpp > a95663f633f376954d4201b6cfbe693429be9c39 > src/tests/registrar_tests.cpp c330af2a190282e159d9ab477cdc36a7881842cd > > Diff: https://reviews.apache.org/r/44511/diff/ > > > Testing > ------- > > Add three sub tests for /weights endpoint registry in this patch: > > 1. Tests whether the weights replicated log is initialized with the > `--weights` flag when bootstrapping the cluster. > 2. Tests whether the weights replicated log can be updated with `/weights` > endpoint. > 3. Tests whether the `--weights` flag is ignored and use the registry value > instead when Mesos master subsequently starts with `--weights` flag still > specified. > > ./src/mesos-tests --gtest_filter=Strict/RegistrarTest.UpdateWeights/* > [==========] Running 2 tests from 1 test case. > [----------] Global test environment set-up. > [----------] 2 tests from Strict/RegistrarTest > [ RUN ] Strict/RegistrarTest.UpdateWeights/0 > [ OK ] Strict/RegistrarTest.UpdateWeights/0 (103 ms) > [ RUN ] Strict/RegistrarTest.UpdateWeights/1 > [ OK ] Strict/RegistrarTest.UpdateWeights/1 (67 ms) > [----------] 2 tests from Strict/RegistrarTest (171 ms total) > > [----------] Global test environment tear-down > [==========] 2 tests from 1 test case ran. (178 ms total) > [ PASSED ] 2 tests. > > > make && make check. > > > Thanks, > > Yongqiao Wang > >
