----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review124519 -----------------------------------------------------------
Maybe all the http auth flag validation code should just go inside the `--authenticate_http` block, and you'll EXIT/WARN if they specify any related flags without enabling http authn. src/slave/slave.cpp (line 395) <https://reviews.apache.org/r/44515/#comment187121> Should we EXIT/WARN if a custom authenticator is used, but --http_credentials is specified (and ignored)? src/slave/slave.cpp (lines 407 - 409) <https://reviews.apache.org/r/44515/#comment187122> Should we also EXIT/WARN if `--authenticate_http` is not set, and a custom authenticator is set: `--http_authenticators != DEFAULT_HTTP_AUTHENTICATOR`? - Adam B On March 20, 2016, 9:50 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44515/ > ----------------------------------------------------------- > > (Updated March 20, 2016, 9:50 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till > Toenshoff. > > > Bugs: MESOS-4849 > https://issues.apache.org/jira/browse/MESOS-4849 > > > Repository: mesos > > > Description > ------- > > Added agent flags for HTTP authentication. > > Three command-line flags have been added to the agent to enable HTTP > authentication: `--authenticate_http`, `--http_credentials`, and > `--http_authenticators`. > > > Diffs > ----- > > src/slave/constants.hpp 4189c07dbad754e51f1a067ecbb4c99ae42a386f > src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 > src/slave/flags.cpp b77afa956834bb5b1f85301d7a5f386ab9da41e3 > src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 > src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5 > > Diff: https://reviews.apache.org/r/44515/diff/ > > > Testing > ------- > > `sudo make check` was used to test on both OSX and Ubuntu 14.04. > > > Thanks, > > Greg Mann > >
