> On March 19, 2016, 11:39 a.m., Joerg Schad wrote: > > src/slave/flags.cpp, line 682 > > <https://reviews.apache.org/r/44515/diff/11/?file=1306305#file1306305line682> > > > > One part I don't like is that the same flag on the master has a > > different name credentials. > > I would suggest to deprecate (in another patch) to deprecate masters > > credentials flag and introduce a new one for that. > > Already have a local patch for that, just interested in your opinion > > first.
Yes, the difference in naming is unfortunate. However, the master's `--credentials` flag is used for several purposes: HTTP authentication, framework authentication, and slave authentication, so I think that the more general name "credentials" makes sense for that reason. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review124401 ----------------------------------------------------------- On March 20, 2016, 5:27 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44515/ > ----------------------------------------------------------- > > (Updated March 20, 2016, 5:27 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till > Toenshoff. > > > Bugs: MESOS-4849 > https://issues.apache.org/jira/browse/MESOS-4849 > > > Repository: mesos > > > Description > ------- > > Added agent flags for HTTP authentication. > > Three command-line flags have been added to the agent to enable HTTP > authentication: `--authenticate_http`, `--http_credentials`, and > `--http_authenticators`. > > > Diffs > ----- > > src/slave/constants.hpp 4189c07dbad754e51f1a067ecbb4c99ae42a386f > src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 > src/slave/flags.cpp b77afa956834bb5b1f85301d7a5f386ab9da41e3 > src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 > src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5 > > Diff: https://reviews.apache.org/r/44515/diff/ > > > Testing > ------- > > `sudo make check` was used to test on both OSX and Ubuntu 14.04. > > > Thanks, > > Greg Mann > >
