-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44515/#review124392
-----------------------------------------------------------




src/slave/flags.cpp (line 685)
<https://reviews.apache.org/r/44515/#comment186914>

    s/could/can ?
    Being more native than me feel free to drop.



src/slave/slave.cpp (line 320)
<https://reviews.apache.org/r/44515/#comment186923>

    Can we add a comment here similar as below.
    // Load credential for master/slave authentication.



src/slave/slave.cpp (line 373)
<https://reviews.apache.org/r/44515/#comment186919>

    Do we actually have to get the authenticator above if this flag is not set?



src/tests/mesos.cpp (line 151)
<https://reviews.apache.org/r/44515/#comment186924>

    /credential/ credential for master/agent authentication


- Joerg Schad


On March 18, 2016, 6:32 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44515/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 6:32 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4849
>     https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added agent flags for HTTP authentication.
> 
> Three command-line flags have been added to the agent to enable HTTP 
> authentication: `--authenticate_http`, `--http_credentials`, and 
> `--http_authenticators`.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp 4189c07dbad754e51f1a067ecbb4c99ae42a386f 
>   src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
>   src/slave/flags.cpp b77afa956834bb5b1f85301d7a5f386ab9da41e3 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
>   src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5 
> 
> Diff: https://reviews.apache.org/r/44515/diff/
> 
> 
> Testing
> -------
> 
> `sudo make check` was used to test on both OSX and Ubuntu 14.04.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to