> On March 21, 2016, 10:02 p.m., Joris Van Remoortere wrote: > > src/common/values.cpp, line 613 > > <https://reviews.apache.org/r/43561/diff/3/?file=1273811#file1273811line613> > > > > @benm I wish we had support for iterating over these splicers eg: > > `foreachtoken(temp, ",\n", [](const string& token) { ... });` > > > > These helpers become rather heavy (at 3 nested) considering their > > utility.
@joris, I think `foreachtoken` is also nested loop. When doing the patches, there're three options to me: FSM, regex and nested loop; FSM & regex seems hard to maintain, so I used nested loop. - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review124545 ----------------------------------------------------------- On March 22, 2016, 9:22 p.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43561/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 9:22 p.m.) > > > Review request for mesos, Alexander Rukletsov, Ben Mahler, and Joris Van > Remoortere. > > > Bugs: MESOS-4627 > https://issues.apache.org/jira/browse/MESOS-4627 > > > Repository: mesos > > > Description > ------- > > Improve Ranges parsing to handle single values. > > > Diffs > ----- > > src/common/values.cpp 9f3c0b9930bd3dd9d84d97119419825862f531c3 > src/tests/resources_tests.cpp 6b004d64bb25112b19fc5d98b5bca874c5329e8c > src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 > > Diff: https://reviews.apache.org/r/43561/diff/ > > > Testing > ------- > > make > make check GTEST_FILTER=~"*" > ./src/mesos-test > > > Thanks, > > Klaus Ma > >
