> On March 18, 2016, 11:42 p.m., haosdent huang wrote:
> > src/examples/long_lived_framework.cpp, line 168
> > <https://reviews.apache.org/r/45067/diff/1/?file=1307190#file1307190line168>
> >
> > I think use
> > ```
> > if (flags.master.isNone()) {
> > EXIT(EXIT_FAILURE)
> > << flags.usage("Missing required option --master");
> > }
> > ```
> > to keep consistent with current codebase would be better
The flag validation lambdas are somewhat newer stylistically, but they are the
recommended way of adding flag validation now.
As the for the `EXIT`, we exit below:
```
if (load.isError()) {
EXIT(1) << flags.usage(load.error());
}
```
(I'll change the `1` to `EXIT_FAILURE`.)
> On March 18, 2016, 11:42 p.m., haosdent huang wrote:
> > src/examples/long_lived_framework.cpp, line 177
> > <https://reviews.apache.org/r/45067/diff/1/?file=1307190#file1307190line177>
> >
> > Should use `build_dir`?
Ah, yes. Missed that :)
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45067/#review124377
-----------------------------------------------------------
On March 23, 2016, 3:50 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45067/
> -----------------------------------------------------------
>
> (Updated March 23, 2016, 3:50 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This gives the example `long-lived-framework` enough options to run outside
> of the build environment.
>
> This also updates:
>
> * The style of the framework code.
> * Gives the `ExecutorInfo` some resources (needed for some cgroups isolators).
> * Restricts the framework to one agent. Otherwise, it would grab a small
> chunk of every machine in the cluster.
> * Adds filters for declined offers.
>
>
> Diffs
> -----
>
> src/examples/long_lived_framework.cpp
> 0000289a0b9dd3d1ce30f20dd9bb381126bff30c
>
> Diff: https://reviews.apache.org/r/45067/diff/
>
>
> Testing
> -------
>
> make check
>
> Ran this on the master node on a Mesos cluster:
> ```
> ./long-lived-framework --master=zk://localhost:2181/mesos
> --executor_uri="https://s3.amazonaws.com/url/to/long-lived-executor";
> --executor_command="LD_LIBRARY_PATH=/path/to/libmesos &&
> ./long-lived-executor"
> ```
>
>
> Thanks,
>
> Joseph Wu
>
>
