----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/#review125185 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/mesos.proto (lines 359 - 360) <https://reviews.apache.org/r/44660/#comment187971> `s/-t/--time/` here and elsewhere? src/docker/executor.cpp (lines 200 - 205) <https://reviews.apache.org/r/44660/#comment187972> This is for backwards compatibility, right? I wouldn't expect the shutdown timeout to impact the kill timeout since no shutdown is occuring, so that might surprise others and its worth saying why we do this. - Ben Mahler On March 23, 2016, 11:25 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44660/ > ----------------------------------------------------------- > > (Updated March 23, 2016, 11:25 p.m.) > > > Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen. > > > Bugs: MESOS-4909 > https://issues.apache.org/jira/browse/MESOS-4909 > > > Repository: mesos > > > Description > ------- > > The docker executor determines how much time it allots the > underlying container to clean up (via passing the timeout to > the docker daemon) based on both optional task's `KillPolicy` > and optional `shutdown_grace_period` field in `ExecutorInfo`. > > > Diffs > ----- > > include/mesos/mesos.proto b965f5a6b1aff28feb2ab088c30ea927b9247403 > include/mesos/v1/mesos.proto d2ab6ed187ec0d0e5dbac92607b612bb55b1a682 > src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e > > Diff: https://reviews.apache.org/r/44660/diff/ > > > Testing > ------- > > The complete chain was tested. See https://reviews.apache.org/r/44662/. > > > Thanks, > > Alexander Rukletsov > >
