> On March 15, 2016, 11:21 p.m., Ben Mahler wrote:
> > src/docker/executor.cpp, lines 657-663
> > <https://reviews.apache.org/r/44660/diff/4/?file=1299829#file1299829line657>
> >
> >     Hm.. ideally we could ignore the docker stop flag if a kill policy was 
> > set, because the user is being explicit about how much time they need. This 
> > is the same as how we ignore the executor shutdown grace period flag if the 
> > executor explicitly sets one.
> 
> Alexander Rukletsov wrote:
>     Yes, that would be ideal. However, we'll learn about kill policy only 
> later, when the task is launched. The case when the user sets both the docker 
> stop timeout and the killpolicy, and the kill policy is smaller than the 
> docker flag seems to be rare to me. Moreover, in such case we give *not less* 
> time than requested. I'd suggest to leave this as is as opposed to saving the 
> docker flag value and deciding later whether we need it or not.

Sounds good.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44660/#review123782
-----------------------------------------------------------


On March 18, 2016, 5:21 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44660/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 5:21 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.
> 
> 
> Bugs: MESOS-4909
>     https://issues.apache.org/jira/browse/MESOS-4909
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The docker executor determines how much time it allots the
> underlying container to clean up (via passing the timeout to
> the docker daemon) based on both optional task's `KillPolicy`
> and optional `shutdown_grace_period` field in `ExecutorInfo`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto deb9c0910a27afd67276f54b3f666a878212727b 
>   include/mesos/v1/mesos.proto a981e750c24cfc48177bbc9ca56f0c3ecfae1a1b 
>   src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e 
> 
> Diff: https://reviews.apache.org/r/44660/diff/
> 
> 
> Testing
> -------
> 
> The complete chain was tested. See https://reviews.apache.org/r/44662/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to