-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45267/#review125197
-----------------------------------------------------------




3rdparty/libprocess/src/subprocess.cpp (line 456)
<https://reviews.apache.org/r/45267/#comment187990>

    Sugguest to add a NOTE that, the envp is environment->size() + 1, so the 
last NULL ptr is not handled (delete).


- Klaus Ma


On March 24, 2016, 11:41 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45267/
> -----------------------------------------------------------
> 
> (Updated March 24, 2016, 11:41 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5021
>     https://issues.apache.org/jira/browse/MESOS-5021
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/subprocess.cpp 
> 16c327db6fde1a1bac92d9e8f7cc80e57b028c1a 
> 
> Diff: https://reviews.apache.org/r/45267/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Reply via email to