> On March 24, 2016, 7:57 p.m., Greg Mann wrote: > > src/cli/execute.cpp, line 215 > > <https://reviews.apache.org/r/43935/diff/3/?file=1309822#file1309822line215> > > > > s/sepcified/specified/ > > Jian Qiu wrote: > Sorry for the typo... please review again.
No worries :-) The patch looks good to me, perhaps mcypark can have a look when he has some cycles. You could contact him directly or ping him on the JIRA ticket to see when he'll have some time to review. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review125329 ----------------------------------------------------------- On March 25, 2016, 1:54 a.m., Jian Qiu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43935/ > ----------------------------------------------------------- > > (Updated March 25, 2016, 1:54 a.m.) > > > Review request for mesos, Greg Mann, Shuai Lin, and Michael Park. > > > Bugs: MESOS-4744 > https://issues.apache.org/jira/browse/MESOS-4744 > > > Repository: mesos > > > Description > ------- > > Allow setting role in mesos-execute. > > > Diffs > ----- > > src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e > > Diff: https://reviews.apache.org/r/43935/diff/ > > > Testing > ------- > > make & make check > > start master. > ./bin/mesos-master.sh --work_dir=/tmp/mesos > > start slave. > ./bin/mesos-slave.sh --work_dir=/tmp/mesos --master=192.168.99.1:5050 > --resources="cpus:1;cpus(test):1;mem:7500;mem(test):7500" > > running mesos-execute without specifying role succeeds. > ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep > 10" --resources="cpus:1;mem:512" > > running mesos-execute with role test succeeds. > ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep > 10" --role="test" --resources="cpus:2;mem:512" > > running mesos-execute with role test1 fails. > ./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep > 10" --role="test1" --resources="cpus:2;mem:512" > > > Thanks, > > Jian Qiu > >
