> On March 19, 2016, 10:10 p.m., Jie Yu wrote: > > src/linux/xfs.cpp, line 17 > > <https://reviews.apache.org/r/44946/diff/3/?file=1304831#file1304831line17> > > > > Move this after below stout headers. > > James Peach wrote: > The Mesos C++ style guide says that this should come first. > > Jie Yu wrote: > Sampled a few files, non of them are in this style. Either the style > guide is not accurate, or we don't follow Mesos style guide consistently > (which is bad). > > Fot the time being, let's just be consistent?
The rule in [our clang-format](https://github.com/apache/mesos/blob/master/support/clang-format#L38-L46) is ``` IncludeCategories: - Regex: '^<.*.h>' Priority: 1 - Regex: '^<.*.hpp>' Priority: 3 - Regex: '^<.*>' Priority: 2 - Regex: '.*' Priority: 4 ``` - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review124427 ----------------------------------------------------------- On March 22, 2016, 11:24 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44946/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 11:24 p.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOS-4828 > https://issues.apache.org/jira/browse/MESOS-4828 > > > Repository: mesos > > > Description > ------- > > Add utility functions to manipulate XFS project quotas. > > > Diffs > ----- > > src/Makefile.am 6552e48eab2708a28dd69adba3ec759cb5aeca4c > src/slave/containerizer/mesos/isolators/disk/xfs/utils.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44946/diff/ > > > Testing > ------- > > Make check. Manual verification. Tests in subsequent patches. > > > Thanks, > > James Peach > >
