> On March 23, 2016, 5:39 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp, lines 17-19 > > <https://reviews.apache.org/r/44946/diff/9/?file=1311203#file1311203line17> > > > > So this is bug of the xfs headers? > > > > I guess it's still not clear to me why this is relevant here. Is it a > > bug of XFS? > > > > It looks like textdomain() is for i18n support. I guess this has to do > > with path names being non ASCII? When ENABLE_GETTEXT is definied here and > > no other dependencies are checked, will XFS headers go the right thing? > > > > This might be too long of a discussion for here so I was suggesting a > > link where the above question is answered (or source).
Yes I'd say this is a bug in the XFS headers. This happens due to the way xfsprogs was built by the distribution. I'm not sure where I would link to, but it's fairly clear from the headers what is going on. > On March 23, 2016, 5:39 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp, line 119 > > <https://reviews.apache.org/r/44946/diff/9/?file=1311203#file1311203line119> > > > > I know I asked this previoiusly but what's the difference between this > > and: > > > > ``` > > fs_disk_quota_t quota; > > ``` > > > > If it's the same, then the more common syntax is preferred because this > > syntax reads like the 1st member of the struct has special some > > meaning/usage. This is a ``C`` zero-initialization. I can either do this or ``memset`` the structure to zero, to get the same result. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review124248 ----------------------------------------------------------- On March 22, 2016, 11:24 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44946/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 11:24 p.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOS-4828 > https://issues.apache.org/jira/browse/MESOS-4828 > > > Repository: mesos > > > Description > ------- > > Add utility functions to manipulate XFS project quotas. > > > Diffs > ----- > > src/Makefile.am 6552e48eab2708a28dd69adba3ec759cb5aeca4c > src/slave/containerizer/mesos/isolators/disk/xfs/utils.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44946/diff/ > > > Testing > ------- > > Make check. Manual verification. Tests in subsequent patches. > > > Thanks, > > James Peach > >
