----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review124827 -----------------------------------------------------------
BTW, should we also add `utils.cpp` to `CMakeList.txt`? src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp (line 94) <https://reviews.apache.org/r/44946/#comment187511> Just some small formatting issues: We try to add Apostrophe for the variables in error/failure messages, e.g., ``` return ErrnoError("Unable to access '" + path + "'"); ``` Could we update the others below :) ? src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp (line 99) <https://reviews.apache.org/r/44946/#comment187512> ditto. src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp (line 104) <https://reviews.apache.org/r/44946/#comment187513> one newline above? src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp (line 139) <https://reviews.apache.org/r/44946/#comment187514> ditto. src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp (line 177) <https://reviews.apache.org/r/44946/#comment187515> ditto. src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp (line 228) <https://reviews.apache.org/r/44946/#comment187516> ditto here. Could we do: ```return Error("Failed to open '" + path + "': " + fd.error()); ``` src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp (line 235) <https://reviews.apache.org/r/44946/#comment187517> ditto. src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp (line 256) <https://reviews.apache.org/r/44946/#comment187518> ditto. src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp (line 264) <https://reviews.apache.org/r/44946/#comment187519> ditto. src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp (line 275) <https://reviews.apache.org/r/44946/#comment187520> ditto. src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp (line 291) <https://reviews.apache.org/r/44946/#comment187521> ditto. src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp (line 299) <https://reviews.apache.org/r/44946/#comment187522> ditto. src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp (line 310) <https://reviews.apache.org/r/44946/#comment187523> ditto. - Gilbert Song On March 21, 2016, 6:20 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44946/ > ----------------------------------------------------------- > > (Updated March 21, 2016, 6:20 p.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOS-4828 > https://issues.apache.org/jira/browse/MESOS-4828 > > > Repository: mesos > > > Description > ------- > > Add utility functions to manipulate XFS project quotas. > > > Diffs > ----- > > src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf > src/slave/containerizer/mesos/isolators/disk/xfs/utils.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44946/diff/ > > > Testing > ------- > > Make check. Manual verification. Tests in subsequent patches. > > > Thanks, > > James Peach > >
